Fix creating main window #3842
Merged
Fix creating main window #3842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window property is used by conditions in multiple places, but it was always available due to the getter function, which is not the expected behavior. Turn it into an empty property, and assign the window only in the open() function, which is the only place where the window is supposed to be created. This fixes the problem that set_application() has no effect, because it's called after the window is presented by _on_file_manager_state_changed().
|
Thanks @City-busz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windowproperty is used by conditions in multiple places, but it was always available due to the getter function, which is not the expected behavior. Turn it into an empty property, and assign the window only in theopen()function, which is the only place where the window is supposed to be created.This fixes the problem that
set_application()has no effect, because it's called after the window is presented by_on_file_manager_state_changed().PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
app_idproperty of the main window is "gaphor", because the window is not associated with the application before shown.Issue Number: N/A
What is the new behavior?
The
app_idproperty of the main window is "org.gaphor.Graphor", the window properly initialized and associated with the application before shown.Does this PR introduce a breaking change?
Other information