Skip to content

Use view switcher in element editor #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Use view switcher in element editor #3846

merged 5 commits into from
Apr 17, 2025

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Apr 13, 2025

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Improve the element editor.

Issue Number: #3831

What is the new behavior?

View switchers are in the element editor.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The style editor can also be added to the element editor/sidebar now.

Also tested with merge conflict.

@amolenaar amolenaar marked this pull request as draft April 13, 2025 11:34
@github-actions github-actions bot added the python Pull requests that update Python code label Apr 13, 2025
@bertob
Copy link
Contributor

bertob commented Apr 14, 2025

The flat view switcher at the top is not the best fit here style-wise. I'd either move it to the bottom (like in the sidebar in e.g. Papers) or go with an inline view switcher at the top.

@amolenaar
Copy link
Member Author

@bertob I played around a bit. I think the bottom bar looks best:

image

This is the inline view switcher:

image

@bertob
Copy link
Contributor

bertob commented Apr 14, 2025

The bottom bar looks good, but I'd go for the wide policy, since there's enough space to fit icon next to label here and it'd avoid some of the whitespace on the sides.

@amolenaar
Copy link
Member Author

The view-switcher-bar does not have that option. I swapped it out for a AdwViewSwitcher:

image

@amolenaar amolenaar requested a review from danyeaw April 15, 2025 20:31
@amolenaar amolenaar marked this pull request as ready for review April 15, 2025 20:32
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Apr 16, 2025
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this looks amazing 🤩!

@amolenaar
Copy link
Member Author

It does, doesn't it?

@danyeaw
Copy link
Member

danyeaw commented Apr 16, 2025

It doesn't need to be part of this PR, but what if we also moved the Open Style Editor button to the Styling view?

@amolenaar
Copy link
Member Author

I'm definitely in favor of integrating that dialog in the main ui. For a next PR, probably ;)

@danyeaw
Copy link
Member

danyeaw commented Apr 16, 2025

I noticed the macOS App test is failing even after trying to rerun it, do you think it is being flaky or something related to the PR?

@github-actions github-actions bot added the python Pull requests that update Python code label Apr 17, 2025
@danyeaw danyeaw removed the python Pull requests that update Python code label Apr 17, 2025
@danyeaw danyeaw merged commit 53390ca into main Apr 17, 2025
25 checks passed
@danyeaw danyeaw deleted the editor-pages branch April 17, 2025 13:13
@amolenaar
Copy link
Member Author

I expect it to be flaky. The macOS 13 build also fails regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants