-
-
Notifications
You must be signed in to change notification settings - Fork 216
Use view switcher in element editor #3846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The flat view switcher at the top is not the best fit here style-wise. I'd either move it to the bottom (like in the sidebar in e.g. Papers) or go with an inline view switcher at the top. |
@bertob I played around a bit. I think the bottom bar looks best: This is the inline view switcher: |
The bottom bar looks good, but I'd go for the wide policy, since there's enough space to fit icon next to label here and it'd avoid some of the whitespace on the sides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this looks amazing 🤩!
It does, doesn't it? |
It doesn't need to be part of this PR, but what if we also moved the Open Style Editor button to the Styling view? |
I'm definitely in favor of integrating that dialog in the main ui. For a next PR, probably ;) |
I noticed the macOS App test is failing even after trying to rerun it, do you think it is being flaky or something related to the PR? |
I expect it to be flaky. The macOS 13 build also fails regularly. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Improve the element editor.
Issue Number: #3831
What is the new behavior?
View switchers are in the element editor.
Does this PR introduce a breaking change?
Other information
The style editor can also be added to the element editor/sidebar now.
Also tested with merge conflict.