Fix empty values in older (pre-3.0) models #3844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those resort to String literals to be on the safe side.
|
Thanks @amolenaar ! |
danyeaw
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Hi @amolenaar, this is a really nice fix and cleanup! Just one nitpick about a comment.
danyeaw
reviewed
Apr 14, 2025
Co-authored-by: Dan Yeaw <dan@yeaw.me>
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Deal with odd cases, e.g. when value of a value is empty.
Issue Number: Fixes #3829
What is the new behavior?
Does this PR introduce a breaking change?
Other information