Rename new-model action to new-window #3811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNOME Shell uses the "new-window" action to open new main windows for an application. Renaming that action to this common name allows application launchers to use it.
|
Thanks @City-busz, that's a nice improvement :) |
|
@all-contributors add @City-busz for bugs, code |
|
I've put up a pull request to add @City-busz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNOME Shell uses the "new-window" action to open new main windows for an application. Renaming that action to this common name allows application launchers to use it.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
GNOME Shell does not provide a "New Window" option for Gaphor, because the "new-window" action is not implemented.
Issue Number: N/A
What is the new behavior?
GNOME Shell provides a "New Window" action for Gaphor that opens a new greeter window if not already present.
Does this PR introduce a breaking change?
Other information