Async actions and event handlers #3772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just tell all sessions to shut down, perform application shutdown if no sessions exist anymore.
2bbcec9 to
18c7bc0
Compare
This makes it easier to support async workloads. File opening has been made async already.
Now we can drop the TaskOwner class
danyeaw
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Thanks @amolenaar, this is a really nice improvement for working with the async code 🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We need to schedule special "background tasks" in order to perform async code.
What is the new behavior?
For EventManager events, allow event handlers to be async functions. This makes it more ideomatic to work with async code.
Actions can also be async. However, an action can only be executed one at a time.
Does this PR introduce a breaking change?
Other information
Cleaned out the
gaphor.asynciomodule. Now it only has 2 functions that can be removed once PyGObject 3.52 has been released.