Copy PNG and SVG to the clipboard #3771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paste function is now async/await instead of callbacks.
4db18eb to
139defc
Compare
danyeaw
approved these changes
Mar 5, 2025
|
|
||
| with Transaction(self.event_manager): | ||
| for i in list(items): | ||
| i.unlink() | ||
|
|
||
| def paste_link(self, view): | ||
| self._paste(view, paste_link) | ||
| self.create_background_task(self._paste(view, paste_link)) |
There was a problem hiding this comment.
Nice idea to use asyncio for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Diagram data can't be copied to other apps.
Issue Number: #3664
What is the new behavior?
Apart from the (internal) copy buffer, also provide PNG and SVG images, so diagrams can be copied in other apps.
Other information