Skip to content

Ellipsize long class names in association property editor #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Feb 21, 2025

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: Fixes #3745

What is the new behavior?

Association member end names are ellipsized, so long names do not make the property editor unnecessary wide.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

@tompkins-ct This is the fix, right?

@amolenaar amolenaar requested a review from danyeaw February 21, 2025 16:55
@tompkins-ct
Copy link

Based on your figure, that's consistent with what I was thinking. The Ellipses look nice on the test label.

Another potential issue is the editable text fields.
It might be good to develop a consistent approach to these editable text fields to prevent the property panel from expanding uncontrollably. My preference would be to grow vertically by the textline height and wrap because that's easier to visually read while editing. Elipses there would make it difficult for larger item names.

It might be a good idea to add a test (probably a test model because it's UI related) with long item names on all text fields so these can be checked in the future with UI changes.

@amolenaar
Copy link
Member Author

@tompkins-ct Thanks for checking.

Text fields are not a problem: the text "scrolls" out of the text field if it's to long. The text entry widget has no feature to wrap, and I think it's not a good idea to use text area's everywhere.

@danyeaw danyeaw added the fix A fix for a bug label Feb 25, 2025
@danyeaw danyeaw merged commit 98f03f8 into main Feb 25, 2025
24 checks passed
@danyeaw danyeaw deleted the ellipsize-long-class-names branch February 25, 2025 20:38
@danyeaw
Copy link
Member

danyeaw commented Feb 25, 2025

Thanks @amolenaar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

association property page overtakes screen when member end name is too large
3 participants