Fix exception when dragging with touch #3746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks @Jummit and congratz on your first commit to Gaphor :) @all-contributors Add @Jummit for bugs and code |
|
I've put up a pull request to add @Jummit! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3741
This doesn't improve touch interaction much, just avoids the context menu code erroring out.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
Issue Number: #3741
What is the new behavior?
Doesn't error.
Does this PR introduce a breaking change?
Other information
It would be nice to improve touch inut overall, like allowing box selection, draging elements and not preserving as much scroll momentum when dragging. I don't have a touch-enabled developing machine, so testing code changes requires a bit of work. Maybe I'll take a stab at it in the future.