Skip to content

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jan 25, 2025

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

We now have different diagram types, instead of one diagram type with a diagramType property.

However, the mapping from diagram type to diagram item was not loaded.

Issue Number: fixes #3698

What is the new behavior?

Diagram type mappings (representations) are loaded.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar added the skip-changelog Do not add this entry to the changelog label Jan 25, 2025
@github-actions github-actions bot added the python Pull requests that update Python code label Jan 25, 2025
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw merged commit a00939b into main Jan 25, 2025
24 checks passed
@danyeaw danyeaw deleted the diagram-on-diagram branch January 25, 2025 23:59
@amolenaar
Copy link
Member Author

Crap. I missed a commit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code skip-changelog Do not add this entry to the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaphor 3.0: new sysml diagram icons not representable on diagrams
2 participants