Convert Preferences and About window to dialogs #3722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
reviewed
Jan 17, 2025
54c92d5 to
5bd9757
Compare
5bd9757 to
019366e
Compare
danyeaw
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Hi @amolenaar, these changes look great! I saw on your todo to get the keyboard preferences updated as well. Should that be a separate PR?
Now it looks similar to the about and preferences dialog.
|
Keyboard shortcuts have been added now. It was a bit of work, since libadwaita provides no default type for this. |
|
Hi @amolenaar, this changes look great! I noticed if you open the keyboard shortcuts from the greeter, then the size is constrained to a little smaller than the window which makes the size a bit awkward, and you have to use horizontal scroll to see everything. Should we resize the greeter a bit to compensate? |
|
@danyeaw I made the greeter window higher, so the keyboard shortcuts dialog fits. |
|
Thanks @amolenaar, that looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The window buttons are placed wrongly if you want to put window button in the top left.
Issue Number: N/A
What is the new behavior?
Preferences, Shortcuts, and About window have been updated to dialogs.
Added a few tweaks to the main window header bars.
Does this PR introduce a breaking change?
Other information