Prepare for native window controls (macOS) #3728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e83563d to
37b83ce
Compare
This will add a bit of consistency to the header bars, and will make using native window decorators easier. This is an implementation of native window controls, which will hopefully make it in GTK 4.18. See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/8071
37b83ce to
664da92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On macOS, the window looks a bit off, since it does not contain the signature window controls.
What is the new behavior?
This is an implementation of native window controls, which will hopefully make it in GTK 4.18.
See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/8071
Does this PR introduce a breaking change?
Other information
This PR requires GTK 4.18, or the latest development version with MR.