Skip to content

Update translation for docs.gaphor.org #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Jan 3, 2025

Translations update from Hosted Weblate for Gaphor/docs.gaphor.org.

Current translation status:

Weblate translation status

@github-actions github-actions bot added the translation Everything regarding translation, localization, and internationalization label Jan 3, 2025
danyeaw
danyeaw previously requested changes Jan 3, 2025
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stansz84, thanks so much for the contribution. We need to please make a few updates so that the French docs build passes validation.

@weblate weblate force-pushed the weblate-gaphor-docs-gaphor-org branch 2 times, most recently from 88bb8fb to ab9b49d Compare January 4, 2025 22:58
@danyeaw
Copy link
Member

danyeaw commented Jan 4, 2025

Hi @amolenaar, I'm not sure why the translations aren't picking up :obj:~gaphor.core.eventmanager.EventManager.handle in the translation. Any ideas?

@amolenaar
Copy link
Member

@danyeaw The text looks okay. What should I do to generate the French docs locally?

@danyeaw
Copy link
Member

danyeaw commented Jan 5, 2025

Hi @amolenaar! Something like this should work:

cd docs
python -m sphinx -T -W --keep-going -b html -d _build/doctrees -D language=fr . _build/html

@weblate weblate force-pushed the weblate-gaphor-docs-gaphor-org branch 2 times, most recently from bc6a753 to cfe300b Compare January 8, 2025 20:25
@amolenaar
Copy link
Member

It looks like the problem is with the markdown files: the markdown files (e.g. undo.md) have a {eval-rst} block. In those blocks, autodoc is used to retrieve the docstring.

In many occasions, the {eval-rst} block works fine, except when a class or method is referenced from the docstring.

I pushed a commit to change the affected files to rst.

@amolenaar
Copy link
Member

The flatpak build now fails because it installs Poetry 2.0.

stansz84 and others added 3 commits January 9, 2025 22:05
Currently translated at 100.0% (1338 of 1338 strings)

Translation: Gaphor/docs.gaphor.org
Translate-URL: https://hosted.weblate.org/projects/gaphor/docs-gaphor-org/fr/
Currently translated at 100.0% (1338 of 1338 strings)

Translation: Gaphor/docs.gaphor.org
Translate-URL: https://hosted.weblate.org/projects/gaphor/docs-gaphor-org/fr/
Currently translated at 100.0% (1338 of 1338 strings)

Translation: Gaphor/docs.gaphor.org
Translate-URL: https://hosted.weblate.org/projects/gaphor/docs-gaphor-org/fr/
@weblate weblate force-pushed the weblate-gaphor-docs-gaphor-org branch from 724aee9 to 81c03d6 Compare January 9, 2025 21:05
@danyeaw
Copy link
Member

danyeaw commented Jan 10, 2025

@amolenaar, it looks like the Flatpak build is now passing.

@amolenaar
Copy link
Member

I'll reapply my fixes and then merge.

So it works with translations. In both cases the docstring contains
a reference. It looks like this breaks when used from an `{eval-rst}`
block in a myst markdown file.
@amolenaar amolenaar requested a review from danyeaw January 10, 2025 10:55
@amolenaar amolenaar dismissed danyeaw’s stale review January 10, 2025 10:56

Issues have been fixed

@amolenaar amolenaar merged commit 2698065 into gaphor:main Jan 10, 2025
24 checks passed
@danyeaw
Copy link
Member

danyeaw commented Jan 10, 2025

Thanks @amolenaar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation translation Everything regarding translation, localization, and internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants