Skip to content

Fix French and Tamil Translation References #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 31, 2024
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Dec 30, 2024

There was a bunch of broken references with the French and Tamil translations, and a single bad URL link for Hungarian. I also enabled pull request building of Spanish, Croatian, French, and Tamil. I also invited @amolenaar to be a maintainer on readthedocs for those extra translation components.

For translations that don't yet have their own readthedocs being built, I'm open to ideas on how we could build them to prevent errors accidentally added. To check a language, we can manually do:

$ python -m sphinx -T -W --keep-going -b html -d _build/doctrees -D language=LANG . _build/html

Where LANG is the two letter translation to build.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Doc builds fail for French and Tamil translations on readthedocs.

Issue Number: N/A

What is the new behavior?

Doc builds should now pass.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added translation Everything regarding translation, localization, and internationalization documentation labels Dec 30, 2024
@danyeaw danyeaw requested a review from amolenaar December 30, 2024 22:11
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amolenaar amolenaar merged commit fd3a5a5 into main Dec 31, 2024
25 checks passed
@amolenaar amolenaar deleted the fix-docs-translations branch December 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation translation Everything regarding translation, localization, and internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants