Use frames in SysML diagrams #3689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @amolenaar, I noticed when the diagram is first created that the box in the corner is large: and then snaps back to size once I click on the diagram. |
|
@danyeaw I fixed the diagram frame label box. |
f88978a to
74b27f5
Compare
* Hides diagram header for SysML diagrams * Automatically adds DiagramFrameItem onto SysML diagram representing the diagram's element * Allow connecting diagram element's ports on the frame when the element is block * Automatically attach activity parameters on the frame * Make frame undeletable * Prevent deleting diagram's element when diagram item which subject is the element is deleted * Replace diagram element's single representation with a frame item on load; otherwise just add a frame onto the diagram surrounding all the items Co-authored-by: Marek Piirikivi <marek.piirikivi@gmail.com>
74b27f5 to
ba4a9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2213 (partially)
Replaces PR #2867.
What is the new behavior?
New SysML diagrams have a frame.
Old style diagrams stay as is.
Does this PR introduce a breaking change?
Other information
@marek-piirikivi I rebased and updated your PR on top of the latest code. I think this is how you expect it to work. If you have time, can you please check 😄 ?
@danyeaw What do you think?