Skip to content

Fix toolbox hotkey showing up in editor #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix toolbox hotkey showing up in editor #3679

merged 1 commit into from
Dec 19, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 19, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: fixes #3653

What is the new behavior?

We should tell the system the event is handled.
Hotkey does non longer show up in instant editor when a character is typed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

We should tell the system the event is handled.
@amolenaar amolenaar requested a review from danyeaw December 19, 2024 07:50
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 19, 2024
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Dec 19, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw merged commit e2c1790 into main Dec 19, 2024
23 checks passed
@danyeaw danyeaw deleted the fix-toolbox-hotkey branch December 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotkey not consumed on element creation
2 participants