Decouple UML concepts from model browser #3633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It contains a lot of UML specific information, such as ownership, and how to deal with specific element types.
Now only the tree model and the relationship item are still relied on.
Now only the TreeModel needs to be obtained dynamically.
ae5d501 to
91604ac
Compare
danyeaw
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the model browser only works with UML (derived) modeling languages.
Issue Number: #3577
What is the new behavior?
The Model Browser model is now part of the model.
It can be exposed through the
ModelingLanguageclass. The tree model type is then instantiated via dependency injection.Every modeling language now has an associated model class for the Model Browser. The model browser takes care to leave the model as is for modeling languages that use the same tree model type (all our current languages).
Other information