Skip to content

Move editing settings to global preferences window #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 2, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Settings for tool reset and automatic model maintenance used to be configured on a per-model basis.

Issue Number: N/A

What is the new behavior?

Settings moved from a model-based to global settings. This should make our settings story more consistent. Now all we have

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I think we discussed this idea a while back as part of Mareike's study on MBSE tooling for neurodivergent people.

NB. Do not forget to run gaphor install-schemas.

@github-actions github-actions bot added the python Pull requests that update Python code label Dec 2, 2024
@amolenaar amolenaar requested a review from danyeaw December 3, 2024 21:18
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Dec 9, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amolenaar, thanks! This is a nice simplification to move these to the main program settings.

@danyeaw danyeaw merged commit 9cd3976 into main Dec 9, 2024
23 checks passed
@danyeaw danyeaw deleted the to-global-settings branch December 9, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants