Skip to content

Build macOS DMG with dmgbuild #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Build macOS DMG with dmgbuild #3612

merged 2 commits into from
Nov 28, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Nov 28, 2024

Let's see if this tool performs better.

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #3605

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Let's see if this tool performs better.
@github-actions github-actions bot added the packaging Update to packaging aspects label Nov 28, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! The approach to build the DMG using Python instead of the create-dmg shell script should hopefully be much more reliable.

@danyeaw danyeaw merged commit cf7e2fa into main Nov 28, 2024
23 checks passed
@danyeaw danyeaw deleted the dmgbuild branch November 28, 2024 20:51
@amolenaar
Copy link
Member Author

Let's see how it works out. We've used dmgbuild in the past and swapped it out for create-dmg.

@danyeaw danyeaw added chore Maintenance related PR and removed packaging Update to packaging aspects labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants