Clean up copy/paste #3589
Merged
Clean up copy/paste #3589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This widget will allow us to implement copy/paste at the right level in the widget hierarchy.
b367b8c to
25f2507
Compare
Instead of a tool.
No more window level actions. This is more in line with how default widgets like text entry work.
25f2507 to
5741a49
Compare
143d72f to
8a2a515
Compare
danyeaw
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have a special copy service.
Issue Number: N/A
What is the new behavior?
This refactoring makes copy/paste work directly on the diagram. This is more in line with how widgets like
Gtk.Entrywork.The copy service is gone.
Does this PR introduce a breaking change?
Other information