Move Relationship and Comment back to the UML model #3555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c884b00 to
45cedaf
Compare
danyeaw
approved these changes
Nov 2, 2024
|
Now we have to figure out how to deal with the Element class. I have an idea: create generic functions (singledispatch) for the features we need for the model browser. Then we do no longer need Element in the core model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
RelationshipandCommentback to the UML modelSaved models have been updated by means of search/replace, no migration has been made.
Comment items have been moved to the UML model, as well as the "general tools" section.
PR Type
What kind of change does this PR introduce?
Issue Number: #3540
Other information
This PR puts the model in a bit of a skew:
Elementis still in core, but some its properties are placeholders for relations defined in the UML model.This used to be (partly) solved by having
RelationshipandCommentas part of the core model. The only odd one out has always beenappliedStereotype.One other thing that's been bothering me is that
Elementis a model type that can be fully generated. It's still a hand written type, sinceDiagramdepends on it.If we proceed, it will not be possible to link comments to diagrams. Not sure if that's a problem, though. We also loose the ability to apply stereotypes to diagrams (#3336), which would be a pity.