Skip to content

macOS: Fix Gaphor model file conformance #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Oct 23, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

According to the apple docs, the conformance type should be some sort of super-type for our Gaphor model.

Since our models are saved as XML, I suppose public.xml is the most approprate.

https://developer.apple.com/documentation/uniformtypeidentifiers/defining-file-and-data-types-for-your-app?language=objc

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

According to the apple docs, the conformance type should
be some sort of super-type for our Gaphor model.

Since our models are saved as XML, I suppose `public.xml` is
the most approprate.

https://developer.apple.com/documentation/uniformtypeidentifiers/defining-file-and-data-types-for-your-app?language=objc
@amolenaar amolenaar changed the title macos: Fix Gaphor model conformance macos: Fix Gaphor model file conformance Oct 23, 2024
@github-actions github-actions bot added the packaging Update to packaging aspects label Oct 23, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw merged commit f1ae597 into main Oct 24, 2024
22 checks passed
@danyeaw danyeaw deleted the macos-file-conformance branch October 24, 2024 01:18
@danyeaw danyeaw removed the packaging Update to packaging aspects label Jan 20, 2025
@danyeaw danyeaw changed the title macos: Fix Gaphor model file conformance macOS: Fix Gaphor model file conformance Jan 20, 2025
@danyeaw danyeaw added the chore Maintenance related PR label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants