Skip to content

Fix file changed notification #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix file changed notification #3537

merged 1 commit into from
Oct 20, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Oct 16, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: Fixes #3536

What is the new behavior?

The file digest is now updated when the model is saved.
Now the popup no longer appears if the model was saved.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Now the popup no longer appears if the model was saved.
@github-actions github-actions bot added the python Pull requests that update Python code label Oct 16, 2024
@amolenaar amolenaar changed the title Update digest after model has been saved Fix file changed notification Oct 18, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @amolenaar!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Oct 20, 2024
@danyeaw danyeaw changed the title Fix file changed notification macOS: Fix file changed notification Oct 20, 2024
@danyeaw danyeaw merged commit 5c23160 into main Oct 20, 2024
22 checks passed
@danyeaw danyeaw deleted the fix-model-changed branch October 20, 2024 17:47
@danyeaw danyeaw changed the title macOS: Fix file changed notification Fix file changed notification Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model changed on disk notification when saving in the program
2 participants