Skip to content

New Adwaita-based dialogs #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 28, 2024
Merged

New Adwaita-based dialogs #3495

merged 6 commits into from
Nov 28, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Sep 17, 2024 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Improved UI when dialogs are shown with grey background (sheets):

image image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • Close status window when model is loaded before the (main) window is shown.

@github-actions github-actions bot added the python Pull requests that update Python code label Sep 17, 2024
@amolenaar amolenaar force-pushed the awdaita-dialogs branch 3 times, most recently from 4d81620 to 2a134b2 Compare September 22, 2024 15:44
@amolenaar amolenaar changed the title Awdaita dialogs Adwaita dialogs Sep 30, 2024
@amolenaar amolenaar force-pushed the awdaita-dialogs branch 2 times, most recently from 26f5335 to 9a18b1d Compare November 2, 2024 09:24
@amolenaar amolenaar force-pushed the awdaita-dialogs branch 2 times, most recently from b33801f to bb4b232 Compare November 20, 2024 14:54
@amolenaar
Copy link
Member Author

Not sure why, but those dialogs do not seem very stable.

@amolenaar amolenaar marked this pull request as draft November 21, 2024 07:45
@amolenaar amolenaar mentioned this pull request Nov 27, 2024
Closed
8 tasks
@amolenaar amolenaar marked this pull request as ready for review November 27, 2024 14:39
@amolenaar
Use AdwDialog for status window
309b014 
Now it shows more nicely on top of a greyed out modeling window.
@amolenaar
Bring Adw.Dialog callback logic to one place
19d0f66
@amolenaar
Copy link
Member Author

Works now that the status window is no longer closed from an idle function.

@amolenaar amolenaar requested a review from danyeaw November 28, 2024 08:26
danyeaw
danyeaw approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@amolenaar amolenaar merged commit 7e3f067 into main Nov 28, 2024
23 checks passed
@amolenaar amolenaar deleted the awdaita-dialogs branch November 28, 2024 21:56
@amolenaar amolenaar changed the title Adwaita dialogs New Adwaita-based dialogs Dec 10, 2024
@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolenaar @danyeaw