Fixed drop of ObjectFlow, ControlFlow, Pin; Fixed autolayout #3479
Conversation
|
Hi @pbrown12303, could you please help me understand that more, aren't you creating a new drop function and registering to be called when an item is dropped? What is the relationship between that and the DiagramItem properties? |
… if ActionItem not present (Issue gaphor#3481) This change ensures that pins can only be dropped on an activity diagram if their owning actions are displayed. It is worth noting that the following behaviors are still allowed based on the default editing rules in gaphor: 1. Multiple instances of a pin may be dropped onto a diagram. They will, however, all be attached to the owning action. 2. A new pin may be dropped on a diagram in a location that does not attach to an action. This pin will not appear in the tree until such time as it is moved to connect to an action.
|
Sorry Dan, that comment was about a different change request (too many parallel change requests). I removed those comments. |
|
I tried combining the two types in the type hints for the register - it doesn't work. |
|
Figured out how to register the same function for two different types - you need to use two |
There was a problem hiding this comment.
Hi @pbrown12303, these changes look great, and thanks for the contribution! In the future, it would be better to create a branch off of main for each issue you are fixing and then open separate pull requests for each topic. It makes it easier to review if unrelated changes are separated.
|
@all-contributors please add @pbrown12303 for bug, code |
|
I've put up a pull request to add @pbrown12303! 🎉 |
As reported in Issue #3477 dropping an existing ObjectFlow or ControlFlow onto an activity diagram does not automatically connect the flows to the end-point elements in the diagram. This change fixes that problem.
As reported in issue #3481, dropping a Pin does not automatically connect it with its owning action.
As reported in issue #2126, autolayout inverts associations, control flows, and object flows.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3477
What is the new behavior?
When a ControlFlow or ObjectFlow is dropped on the diagram the diagram item automatically connects to the head and tail items already in the diagram.
When a Pin is dropped on the diagram it is automatically connected to its owning action
Does this PR introduce a breaking change?
Other information