Skip to content

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Corners do not look nice:

image

Issue Number: N/A

What is the new behavior?

Remove shadow and rounded corners completely, since macOS will deal with this.

Corners look nice:

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Aug 26, 2024
Remove shadow and rounded corners completely, since macOS will deal with
this.
@amolenaar amolenaar requested a review from danyeaw August 26, 2024 08:20
@amolenaar amolenaar changed the title Update platform specific styling for macOS Update platform styling for macOS Aug 26, 2024
It's a layout/stying feature.
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Aug 26, 2024
@danyeaw danyeaw merged commit 873b6f0 into main Aug 27, 2024
21 checks passed
@danyeaw danyeaw deleted the platform-styling branch August 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants