Skip to content

Fix Windows and macOS Build #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 20, 2024
Merged

Fix Windows and macOS Build #3453

merged 5 commits into from
Aug 20, 2024
+17 −29

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Aug 19, 2024 •
edited
Loading

  • Fix an index out of range error when packaging Graphviz on Windows with PyInstaller
  • Overwrite Python using brew prior to installing packages to fix brew linking errors
  • Update the docs to use WinGet for package management since I think that is now the more modern option.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added packaging Update to packaging aspects documentation labels Aug 19, 2024
@danyeaw danyeaw force-pushed the windows-fix-graphviz-build branch from 0cc9af1 to 9a66175 Compare August 20, 2024 13:37
@danyeaw danyeaw force-pushed the windows-fix-graphviz-build branch from 9a66175 to 017fb68 Compare August 20, 2024 13:52
@danyeaw danyeaw marked this pull request as ready for review August 20, 2024 13:57
@danyeaw danyeaw added chore Maintenance related PR and removed packaging Update to packaging aspects labels Aug 20, 2024
@danyeaw danyeaw requested a review from amolenaar August 20, 2024 13:58
@github-actions github-actions bot added the packaging Update to packaging aspects label Aug 20, 2024
@danyeaw danyeaw changed the title Windows Fix Graphviz Packaging Error Fix Windows and macOS Build Aug 20, 2024
@danyeaw danyeaw removed the packaging Update to packaging aspects label Aug 20, 2024
@danyeaw
Copy link
Member Author

danyeaw commented Aug 20, 2024

Hi @amolenaar, I think this is good to go now, fixes the build 👍

@amolenaar
Copy link
Member

Nice! Thanks for fixing the build(s)!

@amolenaar amolenaar merged commit f69ad47 into main Aug 20, 2024
21 checks passed
@amolenaar amolenaar deleted the windows-fix-graphviz-build branch August 20, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar Awaiting requested review from amolenaar

Assignees
No one assigned
Labels
chore Maintenance related PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyeaw @amolenaar