Skip to content

Fix unowned elements #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix unowned elements #3454

merged 2 commits into from
Aug 21, 2024

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

ConnectorEnds show in the model root after a model is loaded.

Issue Number: Fixes #3445

What is the new behavior?

ConnectorEnd, or any MultiplicityElement are no longer shown at top level.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested a review from danyeaw August 20, 2024 10:00
@github-actions github-actions bot added the python Pull requests that update Python code label Aug 20, 2024
@amolenaar amolenaar force-pushed the fix-unowned-elements branch from f525c22 to 0478f3f Compare August 20, 2024 17:14
@amolenaar amolenaar force-pushed the fix-unowned-elements branch from 0478f3f to d04c2c5 Compare August 21, 2024 08:03
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Aug 21, 2024
@danyeaw danyeaw merged commit b15096a into main Aug 21, 2024
21 checks passed
@danyeaw danyeaw deleted the fix-unowned-elements branch August 21, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dangling connector ends
2 participants