Skip to content

Support macOS ARM (Apple Silicon) #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2024
Merged

Support macOS ARM (Apple Silicon) #3397

merged 3 commits into from
Jul 22, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 19, 2024 •
edited by danyeaw
Loading

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

We only build for the Intel platform, and ARM needs to be transpiled.

Issue Number: Fixes #3309

What is the new behavior?

Deliver 2 builds: one for Intel and one for Arm.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • The website should also be updated.
  • Brew cask recipe should fetch version based on architecture.

For hints on matrix builds: https://github.com/orgs/community/discussions/26639

@amolenaar amolenaar marked this pull request as draft July 19, 2024 20:37
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 19, 2024
@amolenaar amolenaar force-pushed the macos-arm branch 8 times, most recently from 34e262c to cb874ac Compare July 20, 2024 16:33
@amolenaar amolenaar marked this pull request as ready for review July 20, 2024 16:56
@amolenaar amolenaar requested a review from danyeaw July 20, 2024 16:56
@amolenaar amolenaar changed the title Support macOS ARM (Apple-Silicon) version Support macOS ARM (Apple Silicon) Jul 20, 2024
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Jul 22, 2024
danyeaw
danyeaw approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @amolenaar!

@danyeaw danyeaw merged commit b5297d1 into main Jul 22, 2024
20 checks passed
@danyeaw danyeaw deleted the macos-arm branch July 22, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native ARM build for macOS
2 participants
@amolenaar @danyeaw