Show main window first when loading model from command line #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an "interactive" option to the session, indicating it's run from a GtkApplication context. With this info, we can schedule a model load call in the background.
Models will be loaded from an idle function anyway.
danyeaw
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
These changes look good, but the main branch with the UML model opens the main window instantaneously on my computer - so its a bit hard for me to tell how big the impact is with this change.
@tompkins-ct are you able to test if this fixes your issue with the really large model?
|
Does that also happen if you open the UML model directly from the command line? |
|
Hi @amolenaar, ahh, ya it does significantly improve launching Gaphor with a model from the command line. |
danyeaw
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a large model is loaded (e.g.
models/UML.gaphor), it looks like nothing happens for a while.Issue Number: fixes #3392
What is the new behavior?
Postpone model loading until the main window is present. This has the additional advantage that dialogs are always placed over a window (no more warnings).