Remove ServiceEvent #3394
Merged
Remove ServiceEvent #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can identify where gi libraries are used and limit its usage.
By default use the system locale, only switch to English when the application is started. This gives a bit more freedom when Gaphor is used as library, and avoids warning messages.
ServiceEvent is not a very useful abstraction for model changes.
# Conflicts: # gaphor/core/modeling/event.py
danyeaw
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @amolenaar. I fixed a merge conflict and made one more update for the ShutdownService in the filemanager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
gaphor.i18n) do not have a external dependencies.ServiceEvent. It was never used as such, and it's the wrong abstraction for an event (e.i. not related to function)Does this PR introduce a breaking change?
Other information