Skip to content

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 10, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: Fixes #3327

What is the new behavior?

Added a checkbox ("readOnly") to the attributes editor. Setting the readOnly property will make it visible in the class.

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I considered editing tags/modifiers directly, but it's hard to keep those up to date. Also, there are a couple of. specific modifiers, and we can't expect users to know those by heart.

@github-actions github-actions bot added the python Pull requests that update Python code label Jul 10, 2024
@amolenaar amolenaar requested a review from danyeaw July 10, 2024 20:29
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Jul 14, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @amolenaar!

@danyeaw danyeaw merged commit 8e62844 into main Jul 14, 2024
@danyeaw danyeaw deleted the read-only-property branch July 14, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to add {readOnly} to property
2 participants