Hi @ghillebrand,

You're definitely on the right track. The code looks okay. To fix the mypy issue, I moved some code around.

Some other changes:

• Merged the code with the main branch. The @transactional has been deleted and the UML model had been updated.
• Fixed a small issue in the model, where 2 relations referred to the same association end on behavior.
• I moved the generation of the trigger/guard/action name to a separate method. I think that makes it somewhat more readable.

I was wondering if trigger and action should actually refer to exiting behaviors, such as a activity, state machine, and Interaction. Currently it's creating a new "Behavior" instance, with no relation to the rest of the model (Behavior should have been an abstract class in the model).

Thank you :) That all makes sense.

ITO the behaviour issue, the OP was happy if the trigger-guard-action could be displayed "properly", without too much methodology behind it. I certainly don't know/ use UML enough to begin to make a call on that!
If you can point me at how to make the text appear above the line, I would happily add that. I would like to understand the drawing side of gaphor better, and that would then meet all the of OP's requirements as I understand them.

My goal is to create a new model type, higraph, which would heavily re-use the STM code, and this was an excellent project to get my head around how the bits of gaphor interact. I should open a feature request, yes? I will outline the steps as I see them, and be guided by you guys on how/ where to implement the various parts.

@ghillebrand

You refer to this?

The text positioning is mostly done automatic. The LinePresentation class initiates text placement and calls text_point_at_line, which will place the text close to the begin/center/end of the line. The position is dependent on the angle of the respected line segment.

Text placement is the same for all lines/vertices.

This PR looks good. So I'll merge it.

@ghillebrand

You refer to this?

The text positioning is mostly done automatic. The LinePresentation class initiates text placement and calls text_point_at_line, which will place the text close to the begin/center/end of the line. The position is dependent on the angle of the respected line segment.

Text placement is the same for all lines/vertices.

Yes, this is what I meant, and this looks like the code I was looking for. Other tools write the text above the line. When I get a chance, I will play with the hinting values, and see how they behave/ influence things. Controlling text position I would like to be able to do for higraphs.