Skip to content

Fix undo and recovery of Dependency type #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2024
Merged

Fix undo and recovery of Dependency type #3384

merged 3 commits into from
Jul 14, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 12, 2024 •
edited by danyeaw
Loading

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

  • undo does not work when changing dependency type
  • dependency type changes are not recorded

Issue Number: N/A

What is the new behavior?

Changes of element type are recorded for undo and recovery.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Jul 12, 2024
@amolenaar amolenaar requested a review from danyeaw July 12, 2024 20:47
@amolenaar amolenaar changed the title Dependency type Fix undo and recovery of Dependency type Jul 12, 2024
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jul 14, 2024
danyeaw
danyeaw approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks great, thanks! Should we do a new minor release?

@danyeaw danyeaw merged commit 799b3f3 into main Jul 14, 2024
18 checks passed
@danyeaw danyeaw deleted the dependency-type branch July 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
fix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolenaar @danyeaw