Skip to content

Fix deletion of attribute/operation in element editor #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix deletion of attribute/operation in element editor #3363

merged 1 commit into from
Jun 25, 2024

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

  • (regression) Deletion of attribute/operation/enumeration/parameter in property editor does not work.

Issue Number: N/A

What is the new behavior?

Deletion works: it's wrapped in a transaction.

Other information

Other things I like to fix here:

  • Double click to edit a stereotype value
  • Attribute/operation/enumeration reorder does not properly redraw the diagram item.

@amolenaar
Fix deletion of attribute/operation in element editor
dd6f5b5 
Unlinking was not wrapped in a transaction.
@github-actions github-actions bot added the python Pull requests that update Python code label Jun 24, 2024
danyeaw
danyeaw approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added bug An issue in the application and removed python Pull requests that update Python code labels Jun 25, 2024
@danyeaw danyeaw merged commit 4fb7a9e into main Jun 25, 2024
@danyeaw danyeaw deleted the fix-delete-attribute branch June 25, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
bug An issue in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolenaar @danyeaw