Fix select association AssertionError #3353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions do not work *that* well when there's already a transaction active and the event queue is not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The problem is that Transaction handling has some caveats at the moment. this is because events are immediately forwarded to the undo manager when they happen, contrary to the "normal" behavior, which makes sures events are executed in order.
This gets a bit troublesome when a new transaction is started while there are still events in the queue. This PR fixes that for association end names by only starting a transaction if the change is not made twice.
Issue Number: Fixes #3348
What is the new behavior?
Selecting an association with association ends filled in does no longer cause an exception.
Does this PR introduce a breaking change?
Other information
The real solution is fixing #3351.