Skip to content

Improve check to avoid cycles in ownership #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

Improve check to avoid cycles in ownership #3343

merged 1 commit into from
Jun 12, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jun 4, 2024 •
edited by danyeaw
Loading

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Fixes #3229.

What is the new behavior?

Check fir all parents before allow an owner to change.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Jun 4, 2024
@amolenaar amolenaar force-pushed the fix-sub-package-disappear branch from 308d9c8 to 30ec4dd Compare June 4, 2024 21:56
@amolenaar amolenaar force-pushed the fix-sub-package-disappear branch from 30ec4dd to f5aedd1 Compare June 4, 2024 22:04
@amolenaar amolenaar requested a review from danyeaw June 4, 2024 22:10
danyeaw
danyeaw approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @amolenaar!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jun 12, 2024
@danyeaw danyeaw merged commit 4d5ae0e into main Jun 12, 2024
@danyeaw danyeaw deleted the fix-sub-package-disappear branch June 12, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
fix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sub package will disappear when dragging parent package insert under to sub package
2 participants
@amolenaar @danyeaw