Skip to content

fixed execution issues in scripting docs #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

mikekidner
Copy link
Contributor

Updated docs so that cells execute. Simplified validation rules so they apply to my_model

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • [ x] Documentation content changes

What is the current behavior?

Issue Number: 3312

What is the new behavior?

Scripting docs build with all example code in code-cells

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

@mikekidner
Copy link
Contributor Author

Not sure why the docs fail to build here. They build locally. It may be something to do with the session() getting re established (L244).

amolenaar added 2 commits June 5, 2024 22:17
The main problem is that if you create a bare session,
all services, including the ones that require GTK are
loaded. Instead we should only provide the required services,
so that we do not need GTK.
@github-actions github-actions bot added the python Pull requests that update Python code label Jun 5, 2024
@amolenaar
Copy link
Member

Not sure why the docs fail to build here. They build locally. It may be something to do with the session() getting re established (L244).

One problem was that if you create a Session(), it also loads the GUI services. I changed that to only load the required services. Secondly it was an issue while loading the entry points. It should only load the requested ones, no other.

@mikekidner
Copy link
Contributor Author

Thank you @amolenaar

@amolenaar amolenaar merged commit 5e3a9af into gaphor:main Jun 6, 2024
@mikekidner mikekidner deleted the 3312_docs_import_missing branch October 24, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants