Fix model entry shows editable #3333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "editing" property on the TreeItem needs to be reset when editing is done.
No need for a start_editing() method for tables in property pages.
danyeaw
approved these changes
Jun 1, 2024
|
Thanks @amolenaar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When you create a diagram and add an element. the diagram shows in editable mode in the model browser.
Issue Number: fixes #3326
What is the new behavior?
Editable mode is restored.
I also simplified the code a bit regarding editing.
I want to figure out if er actually need an
editingproperty in the model class. Maybe something for a future PR ;).Does this PR introduce a breaking change?
Other information