Get rid of ModelLoaded event (recovery 1/3) #3319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had three events: SessionCreated, ModelLoaded, and ModelReady. SessionCreated is emitted when a new session is launched. A session may be based on an existing model (`filename` is set). ModelLoaded is emitted when a model is loaded, and it also contains the file name ModelReady is emitted when a model is loaded. There's some overlap in those events. Back in the day we had the option to load a model in an existing session. We do not allow that anymore. Therefore the ModelLoaded event is a bit redundant.
This was referenced May 25, 2024
danyeaw
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Issue: #2831
What is the current behavior?
We had three events: SessionCreated, ModelLoaded, and ModelReady.
SessionCreated is emitted when a new session is launched. A session may be based on an existing model (
filenameis set).ModelLoaded is emitted when a model is loaded, and it also contains the file name
ModelReady is emitted when a model is loaded.
What is the new behavior?
Cleaned up event structure.
There's some overlap in those events. Back in the day we had the option to load a model in an existing session. We do not allow that anymore. Therefore the ModelLoaded event is a redundant and has been removed.
Does this PR introduce a breaking change?
Other information
I ran into this while implementing #3284.