Fix Hypothesis Tests action timeout #3317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
approved these changes
May 23, 2024
There was a problem hiding this comment.
Thanks @teunhoevenaars! This is another great update to our hypothesis tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to earlier refactoring of
test_auto_layoutingI've greatly reduced the scope oftest_model_consistencyto allow it to complete within an acceptable time. The RuleBasedStateMachine is now confined to generating 5 sequences with each 100 rule-callsPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Hypothesis tests always time out: https://github.com/gaphor/gaphor/actions/workflows/hypothesis-test.yml
Issue Number: N/A
What is the new behavior?
Hypothesis test completes in few minutes
Does this PR introduce a breaking change?
Other information
Settings are defined without any decent knowledge of the program and intention of the test. As such, I imagine they need tweaking.