Skip to content

Skip plugin test if internet is not available #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

I ran into this while coding in the garden. Let's skip the one test that requires access to PyPI if no internet access is available.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested a review from danyeaw May 4, 2024 12:23
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, garden coding is nice 🌻

@danyeaw danyeaw added the chore Maintenance related PR label May 4, 2024
@danyeaw danyeaw merged commit 25d7ea9 into main May 4, 2024
@danyeaw danyeaw deleted the test-without-internet branch May 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants