Ignore event_type to prevent unexpected model changed popup #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including small changes on function calls
3 tasks
amolenaar
reviewed
Apr 29, 2024
gaphor/ui/filemanager.py
Outdated
Comment on lines
337
to
339
| time.sleep(2) | ||
| self.filename = filename | ||
| self._update_monitor() |
There was a problem hiding this comment.
This should be handled via GLib.timeout_add. This way the whole UI freezes.
There was a problem hiding this comment.
in the end, the timeout really did not fully resolve this... I still saw the popups. Therefore, I just ran Gaphor with debugger and realized that the popups on Mac are triggered specifically by ATTRIBUTE_CHANGED events, which I don't think are events we're interested in. As such, I've now added a check against this event-type, which resolves this issue. Happy to hear your thoughts on this!
danyeaw
approved these changes
May 5, 2024
|
Works well. It doesn't trigger if I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3275
What is the new behavior?
time-out after save action, before file monitor is restarted
Does this PR introduce a breaking change?
Other information