Update screenshots for newer libadwaita style #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
reviewed
Apr 28, 2024
There was a problem hiding this comment.
Hey @mikekidner, this is really awesome! Just one comment about one of the image changes. Would you also be interested in updating the screenshots in these locations as well?
- https://github.com/flathub/org.gaphor.Gaphor/tree/master/screenshots
- https://github.com/gaphor/gaphor.github.io/tree/main/images
The first one update the screenshots on https://flathub.org/apps/org.gaphor.Gaphor and the other one updates them on https://gaphor.org
There was a problem hiding this comment.
Could we scale this one back down? It currently takes up a whole visual page up in the docs: https://gaphor--3277.org.readthedocs.build/en/3277/first_model.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update png images for docs, using latest gaphor build.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3274
What is the new behavior?
Does this PR introduce a breaking change?
Other information