Control visibility of requirements #3249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon changing requirement text, id or toggling visibility of text
allowing different diagram properties for the same requirement, such as text visibility
covering use of button and auto-reset of height upon text change
|
hi @marek-piirikivi, I recently discovered gaphor and as an exercise to get to know this library a little better I picked up your feature request (given the first-timers-only flag)! I would love to here if this PR addresses your request adequately :). Many thanks in advance for your feedback. |
took example from BlockItem
teunhoevenaars
commented
Apr 13, 2024
amolenaar
requested changes
Apr 15, 2024
separate Requirement properties from RequirementItem properties
instead of earlier RESET_
|
Thanks a lot for the review @amolenaar! I believe I've processed all your comments :) |
|
Thanks @teunhoevenaars. The code looks really good and it works perfectly! @all-contributors: Add @teunhoevenaars for code. |
amolenaar
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that addresses feature request to support controlling visibility of requirement's text
PR Checklist
Please check if your PR fulfills the following requirements:
Additionally:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2967
What is the new behavior?
Does this PR introduce a breaking change?
hopefully not, but would love to hear your verdict :)
Other information