Skip to content

Refactor align service and cleanup unused arguments #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

Nothing new. Just a bit of maintenance.

@amolenaar amolenaar requested a review from danyeaw March 8, 2024 19:03
@github-actions github-actions bot added the python Pull requests that update Python code label Mar 8, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring and cleanup @amolenaar!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Mar 10, 2024
@danyeaw danyeaw changed the title Boyscouting Refactor align service and cleanup unused arguments Mar 10, 2024
@danyeaw danyeaw merged commit b758ea0 into main Mar 10, 2024
@danyeaw danyeaw deleted the boyscouting branch March 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants