Element selected in Model Browser shows in Property Editor #3148
Conversation
6c42482 to
2f8e380
Compare
2f8e380 to
ec970f1
Compare
|
@danyeaw By separating the model and presentation specific properties, I found out that some property editors are now applied to elements they were not applied to before. E.g. Same goes for attributes and operations on any model element that inherits from We can explicitly blacklist those cases, but I'm not sure if we should. What do you think? |
There was a problem hiding this comment.
Hi @amolenaar, wow, this is a really nice feature to be able to show the property editor from the model browser!
One thing I noticed while testing this:
- Create a Class and a Block
- Select the Block in the Diagram -> Block Property Page is shown
- Select the Class in the Model Browser -> Class Property Page is shown
- Try to click on the Block in the Diagram again -> Class Property Page is still shown
|
Thanks for testing this. It's a bit tricky to orchestrate the events coming both from the model browser and diagram. I'll have a look into this. The problem is that |
|
@danyeaw I think I resolved the (re)selection issue. |
Attribute, operation, enumeration, and stereotype pages are split.
Only needs the model.
In line with name editor.
c2f3c7d to
5a5d99f
Compare
Make sure we only show editors for elements that can actually show it.
So we can trigger the event when a user (re)selects an already selected element on a diagram. This is important, since reselecting does not work as expected after an element has been selected in the model browser.
5a5d99f to
4cda17e
Compare
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only items selected in a diagram are shown in the Property Editor.
Issue Number: Fixes #2545
What is the new behavior?
When you select an element in the Model Browser, it will show in the Property Editor.
Property pages that contain both model and presentation settings (normally a Show Something setting) have been split in two pages.
Does this PR introduce a breaking change?
Other information
Still to do: