Skip to content

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Feb 22, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Block stereotype is always shown

Issue Number: Fixes #2975

What is the new behavior?

Show only "block" stereotype if no other stereotypes are applied.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I'm not sure if this should be applied to other similar elements.

@amolenaar amolenaar requested a review from danyeaw February 22, 2024 19:33
@github-actions github-actions bot added the python Pull requests that update Python code label Feb 22, 2024
@danyeaw
Copy link
Member

danyeaw commented Feb 23, 2024

@amolenaar When I tested this, I didn't see a stereotype when I create a block (with no other stereotypes applied).

@amolenaar
Copy link
Member Author

Thanks. I should have checked that properly. Now it's fixed.

@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Feb 25, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice idea to add some additional tests as well.

@danyeaw danyeaw merged commit d72f894 into main Feb 25, 2024
@danyeaw danyeaw deleted the block-stereotypes branch February 25, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal or toggle of <<Block>> on stereotyped blocks
2 participants