Fix file saving for FreeDesktop Portals #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding an extension (which does not sync via XDP portals), provide a default name with extension. This allows users to easily change the file name, with the extension already visible in the file entry field. Do no longer "magically" add an extension.
Explicit extension is no longer needed, and it requires a file name now.
f9e1f3c to
705854a
Compare
danyeaw
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Files are not properly saved from Flatpaks if you do not define the
.gaphorextension to the file.Issue Number: #3085
What is the new behavior?
Instead of adding an extension (which does not sync via XDP portals), provide a default name with extension.
This allows users to easily change the file name, with the extension already visible in the file entry field.
Do no longer "magically" add an extension.
Does this PR introduce a breaking change?
Other information