Update Adwaita style #3051
Merged
Update Adwaita style #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces visual enhancements to the application's interface, aiming to provide a flatter design that aligns better with macOS aesthetics. It also includes changes to the window management behavior in the console and error reports plugins, making windows present themselves in a more user-friendly manner.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the visual changes are consistent across different platforms and adhere to the application's design language.
- Verify that the removal of padding in the toolbar does not cause any layout issues or inconsistencies with the intended design.
- Consider the broader impact of the UI changes on the user experience, especially for users on operating systems other than macOS.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
01d75e6 to
0b4fdc7
Compare
Also fixes closing the window.
0b4fdc7 to
836b16a
Compare
danyeaw
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The interface is a bit more flat. This makes it look a bit less out of place on macOS at least ;).
Does this PR introduce a breaking change?
Other information
Also made the Error Reports window use CSD.