Skip to content

Odds and ends #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Odds and ends #3055

merged 8 commits into from
Jan 30, 2024

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jan 26, 2024

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Just a few small left-over fixes.

What is the new behavior?

  • Fix preferences width
  • Fix show-editors button style
  • Add styling for Association, and Connector item flow
  • Add styling for Association ends
  • CSS styling for Lifeline lifetime
  • Add CSS styling for diagram pentagon (top left marker)
  • Interaction text should be left aligned (interaction > pentagon)
  • Fix issue with LifeLine when upper handles are moved (lifetime line is out of place)
  • Preferences pane no longer uses extra width.

Does this PR introduce a breaking change?

  • Yes
  • No

@amolenaar amolenaar marked this pull request as draft January 26, 2024 09:08
@amolenaar amolenaar changed the title A few small fixes Odds and ends Jan 26, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request focuses on refactoring and cleanup tasks, including adjustments to preferences width, button styles, and various CSS styling enhancements for different components within the application. It aims to improve the user interface without introducing any breaking changes.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the refactoring efforts maintain or improve the readability and maintainability of the codebase.
  • Verify that the CSS changes are consistent across different browsers and platforms to maintain a uniform user experience.
  • Consider the potential impact of these styling changes on the accessibility of the application, ensuring that it remains usable for all users.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@github-actions github-actions bot added the python Pull requests that update Python code label Jan 28, 2024
@amolenaar amolenaar marked this pull request as ready for review January 28, 2024 18:21
@amolenaar amolenaar requested a review from danyeaw January 28, 2024 18:21
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar, just one nitpick 😄

@amolenaar amolenaar merged commit 14ac6de into main Jan 30, 2024
@amolenaar amolenaar deleted the boyscouting branch January 30, 2024 08:22
@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants